This is the mail archive of the ecos-bugs@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001125] New HAL for the Stellaris EK-LM3S811 board


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001125

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jifl@ecoscentric.com
               Flag|                            |Patch_or_Contribution+

--- Comment #32 from Jonathan Larmour <jifl@ecoscentric.com> 2011-02-09 01:25:40 GMT ---
I've scanned through the patches and nothing major has leapt out at me.

My only comments are essentially cosmetic:

You don't need the memory segments if there's only one of them, and indeed you
have (correctly) not defined CYGBLD_REDBOOT_MAX_MEM_SEGMENTS. And RedBoot
probably will never be supported anyway. So that function can just go away.

The HAL_VAR_INTERRUPT_* macros should go - if they're not defined, the code in
the arch HAL which uses them should do the right thing.

And utterly trivial: the default_ROM.ecm has "template default" in it. Your
documentation uses the minimal template, not default, so by rights the .ecm
should have "template minimal". I don't know about anyone else, but I look at
the template line of .ecm files to see what template this .ecm should be
applied to.

All in all, it's a very good quality patch. Thanks!

Jifl

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]