This is the mail archive of the
ecos-bugs@sourceware.org
mailing list for the eCos project.
[Bug 1001177] Redboot DHCP client race condition, XID, and retryproblems.
- From: bugzilla-daemon at bugs dot ecos dot sourceware dot org
- To: ecos-bugs at ecos dot sourceware dot org
- Date: Fri, 25 Mar 2011 16:20:37 +0000
- Subject: [Bug 1001177] Redboot DHCP client race condition, XID, and retryproblems.
- Auto-submitted: auto-generated
- References: <bug-1001177-13@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001177
--- Comment #6 from Grant Edwards <grant.b.edwards@gmail.com> 2011-03-25 16:20:30 GMT ---
(In reply to comment #2)
> - It would be nice (although admittedly arguably an enhancement) for
> all of bootp/dhcp support to be removable by config option. There
> are many instances where redboot is only ever given a static IP,
> so this code is just taking up space.
I've create a new CYGPKG_REDBOOT_NETWORKING_BOOTP which now contains
CYGSEM_REDBOOT_NETWORKING_DHCP and CYGSEM_REDBOOT_NETWORKING_VERBOSE_BOOTP.
I'm wondering about the latter names. Are names supposed to reflect
package heirachy like more like this?
CYGPKG_REDBOOT_NETWORKING
CYGPKG_REDBOOT_NETWORKING_BOOTP
CYGPKG_REDBOOT_NETWORKING_BOOTP_DHCP
CYGPKG_REDBOOT_NETWORKING_BOOTP_VERBOSE
CYGSEM_REDBOOT_DEFAULT_NO_BOOTP is still contained within
CYGDAT_REDBOOT_DEFAULT_IP_ADDR but now it's active_if
CYGPKG_REDBOOT_NETWORKING_BOOTP. I'm not sure I like that.
Should CYGSEM_REDBOOT_DEFAULT_NO_BOOTP be moved into
CYGPKG_REDBOOT_NETWORKING_BOOTP?
If so, should it be made active_if CYGDAT_REDBOOT_DEFAULT_IP_ADDR, or
should we allow people to set CYGSEM_REDBOOT_DEFAULT_NO_BOOTP without
providing a default IP address. That would allow a configuration with
bootp built, no default IP address, but bootp _use_ disabled by
default. Bootp usage could still be enabled in flash config,
initiated manually via "ip -v", or a default IP could be configured in
flash.
AFAICT, that particular combination wasn't something that could be
done with the previous code. Without a default IP address bootp was
always enabled by default (but could be overridden via flash config).
I don't have a strong opinion one way or the other, but if I were to
pick, I'd move CYGSEM_REDBOOT_DEFAULT_NO_BOOTP into
CYGPKG_REDBOOT_NETWORKING_BOOTP and make it independent of whether
CYGDAT_REDBOOT_DEFAULT_IP_ADDR is set or not. Who are we to say that
no default IP address and bootp built but disabled by default isn't
useful to somebody?
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.