This is the mail archive of the
ecos-bugs@sourceware.org
mailing list for the eCos project.
[Bug 1001180] TTY driver to accommodate more than 4 serial ports.
- From: bugzilla-daemon at bugs dot ecos dot sourceware dot org
- To: ecos-bugs at ecos dot sourceware dot org
- Date: Tue, 29 Mar 2011 09:20:49 +0100
- Subject: [Bug 1001180] TTY driver to accommodate more than 4 serial ports.
- Auto-submitted: auto-generated
- References: <bug-1001180-13@http.bugs.ecos.sourceware.org/>
Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001180
--- Comment #6 from Ilija Kocho <ilijak@siva.com.mk> 2011-03-29 09:20:46 BST ---
(In reply to comment #4)
> Thank you for the patch and usage snippets. I take this opportunity and
> also entered the same conditional include in termiostty.c. Also it
> seemed to me that CYGDAT_IO_SERIAL_TTY_INLINE is more conventional name
> for this case. I mean that then you define "hooked-to" serial/io config,
> say a component CYGPKG_IO_SERIAL_TTY_EXTRA which will contain such a
> cdl_option to define a file name. Why *_INLINE. In fact that is not a
> header as such, and an included C source code. I'll attach a bit updated
> patch.
Thank you for termios patch.
The idea with my naming is to continue macro sequence present already in tty.c
CYGPKG_IO_SERIAL_TTY_TTY0 .. CYGPKG_IO_SERIAL_TTY_TTY3 then
CYGPKG_IO_SERIAL_TTY_ADD. Maybe it could be CYGPKG_IO_SERIAL_TTY_PLUS or, to
emphasis that it is an inline: CYGPKG_IO_SERIAL_TTY_PLUS_INL (.inl is also
extension for included file).
Also we could add some comment in front of the macro:
// CYGPKG_IO_SERIAL_TTY_PLUS_INL macro provides for user inclusion of
additional
// TTY devices. Included file should be typically placed in serial device
include
// directory. It should be accompanied by a cdl_component that shall define the
// macro as well provide as TTY device configuration, as a part of serial
device // cdl file.
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.