This is the mail archive of the ecos-bugs@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001253] Kernel tests on small memory targets


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001253

--- Comment #27 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2011-07-06 15:29:57 BST ---
Ilija, and the last minor note. IMHO, in those other diffs for kernel
tests is preffered to use

#if (CYGMEM_REGION_ram_SIZE <= 32768)

check instead of

#if defined(CYGMEM_REGION_ram_SIZE) && (CYGMEM_REGION_ram_SIZE <= 32768)

The checks are the same here, but, the first check makes compiler to
generate a warning if CYGMEM_REGION_ram_SIZE is not defined:

*:warning: "CYGMEM_REGION_ram_SIZE" is not defined

if we use ``-Wundef`` flag (and we use it in eCos) and (IMO) it's good
to know about undef, and with the second check compiler won't disturb
us.

However, this is a matter of taste. The choise is yours.

Then we would add

#define TINY_SYS (CYGMEM_REGION_ram_SIZE <= 32768)
#define PONY_SYS (!TINY_SYS && (CYGMEM_REGION_ram_SIZE <= 49152))
#define BABY_SYS (!TINY_SYS && !PONY_SYS && (CYGMEM_REGION_ram_SIZE <= 65536))

and check if TINY_SYS ... elif PONY_SYS ... :-)

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]