This is the mail archive of the ecos-bugs@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001453] CAN IO package: wider flags field, flag to reportreturn to 'error active' mode


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001453

--- Comment #8 from Sergei Gavrikov <sergei.gavrikov@gmail.com> 2012-01-19 20:45:54 GMT ---
(In reply to comment #7)
> Yet more needed change:
> 
> - since flags will be 32 bits wide, then the flag_mask field in
> cyg_can_callback_cfg_st must be expanded too. Must do a typedef (or a
> #define?) for flags instead of using cyg_uint32, I missed the
> flag_mask expansion because of this.
> 
> - in can_callbacks_t, describing the function pointers accessible to
> the low level drivers, xmt_msg is today:
> 
> void (*xmt_msg)(can_channel *chan, void *pdata)
> 
> I'd like to have instead:

[snip]

So far only one comment.

Still try to be very careful when planning to change generic CAN I/O
API. There is not only a dependence (LPC2XXX).

  % ecosconfig list | grep DEVS_CAN
  Package CYGPKG_DEVS_CAN_AT91SAM7 (AT91SAM7 CAN device drivers):
  Package CYGPKG_DEVS_CAN_LOOP (Loop CAN device drivers):
  Package CYGPKG_DEVS_CAN_LPC2XXX (LPC2xxx CAN device drivers):
  Package CYGPKG_DEVS_CAN_MCF52xx_FLEXCAN (MCF52xx FlexCAN device drivers):

Sergei

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]