This is the mail archive of the ecos-bugs@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001569] Cortex-M arch. whitespace cleanup.


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001569

Jonathan Larmour <jifl@ecoscentric.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #1708|                            |assignment+, review+
               Flag|                            |

--- Comment #5 from Jonathan Larmour <jifl@ecoscentric.com> 2012-04-23 17:59:47 BST ---
(From update of attachment 1708)
Actually hold back on that commit. Just looking at the patch again, I noticed
some of the indentation in cortexm_stub.c has gone a bit wrong with the tab
removal. For example in get_register():
     if (REGSIZE(reg) > sizeof(target_register_t) || offset == -1)
-    return -1;
+    return -1;

The return should still be indented. There are other examples, but only in that
file. You can go ahead and commit on the assumption those are fixed.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]