This is the mail archive of the ecos-bugs@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug 1001606] Enable the cache on Kinetis in RAM startup mode


Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001606

Bernd Edlinger <bernd.edlinger@hotmail.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bernd.edlinger@hotmail.de

--- Comment #30 from Bernd Edlinger <bernd.edlinger@hotmail.de> 2012-10-27 08:56:30 BST ---
Hi Ilija,

just one or two things:

In macro CYGHWR_HAL_KINETIS_CACHE_WAIT
if the priorities do not need to be swapped, the delay loop seems to be
missing.

and generally the macro parameters should be used in brackets:
example:
#define CYGHWR_HAL_KINETIS_AXBS_CRS_PCTL(_x_)  ((_x_ <<
CYGHWR_HAL_KINETIS_AXBS_CRS_PCTL_S)...

here _x_ could be an expression and the macro should be written this way:
#define CYGHWR_HAL_KINETIS_AXBS_CRS_PCTL(_x_)  (((_x_) <<
CYGHWR_HAL_KINETIS_AXBS_CRS_PCTL_S)...

same for CYGHWR_HAL_KINETIS_AXBS_PRS_MASTER_S,
CYGHWR_HAL_KINETIS_AXBS_PRS_MASTER_PRIO, CYGHWR_HAL_KINETIS_AXBS_CRS_ARB,
CYGHWR_HAL_KINETIS_CACHE_WAIT: parameter lmem_p used wwithout brackets.

Regards,
Bernd Edlinger.

-- 
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]