This is the mail archive of the
ecos-devel@sourceware.org
mailing list for the eCos project.
Re: RedBoot patches regarding redboot_getc_terminate
- From: Andrew Lunn <andrew at lunn dot ch>
- To: "Doyle, Patrick" <Patrick_Doyle at dtccom dot com>
- Cc: "'ecos-devel at sources dot redhat dot com'" <ecos-devel at sources dot redhat dot com>, 'Andrew Dyer' <adyer at righthandtech dot com>
- Date: Thu, 18 May 2006 15:26:21 +0200
- Subject: Re: RedBoot patches regarding redboot_getc_terminate
- References: <F7F756E5ED50F345959AE893AD2F15660A222B@dtcsrvr09.dtccom.com>
On Thu, May 18, 2006 at 09:17:15AM -0400, Doyle, Patrick wrote:
> Sometime since September of 2005, we updated our local eCos repository,
> which includes Andrew Dyer's RedBoot patches to call
> 'redboot_getc_terminate()' in various error scenarios. Since that time, we
> have observed that anytime we use YMODEM to download code to our boards, it
> terminates with an error message.
>
> I hate training myself to ignore error messages... it always comes back to
> haunt me.
>
> So, I looked into this, and I see in 'load_elf_image()', near line 455 of
> "load.c", there is a call to 'redboot_getc_terminate()' with an an argument
> of 'true', indicating that the data transfer should be aborted. I changed
> the abort flag back to 'false', and things have returned to normal for us.
>
> However, before I submit a formal patch undoing the work that Andrew did
> (which had to do with terminating TFTP transfers gracefully), I thought I
> would check in with folks, Andrew especially.
>
> What do folks think? Should I generate the one line patch (along with the 5
> line ChangeLog entry)?
What happens to TFTP transfers with your change? Are they terminated
gracefully? Or do they hang around until the server times out and
kills them?
Andrew