This is the mail archive of the
ecos-discuss@sourceware.cygnus.com
mailing list for the eCos project.
Re: small bug in aeb_serial driver
- To: Dave Airlie <david dot airlie at drua dot ie>
- Subject: Re: [ECOS] small bug in aeb_serial driver
- From: Jonathan Larmour <jlarmour at redhat dot co dot uk>
- Date: Wed, 02 Feb 2000 16:29:14 +0000
- CC: ecos-discuss at sourceware dot cygnus dot com
- Organization: Red Hat UK Ltd.
- References: <Pine.LNX.4.10.10002011741420.31158-100000@gold.drua.ie>
Dave Airlie wrote:
>
> Hi,
> I spotted a bug in 1.2.1 arm AEB serial driver that is still in
> CVS... the patch below fixes it... the isr symbol is a #define in
> serial.h, so like is done for lsr earlier in the file I've put the _
> before the real one...
>
> all small letter #defines are not nice things
>
> this bug doesn't break anything but it does confuse things when reading
> the code..
Thanks for the patch, if you don't mind I think I will fix the real problem
instead - the lower-case #defines in aeb_serial.h.
I'd be grateful if someone else could submit a patch for the other drivers
in a similar way (see anon CVS).
Jifl
--
Red Hat, 35 Cambridge Place, Cambridge, UK. CB2 1NS Tel: +44 (1223) 728762
"Plan to be spontaneous tomorrow." || These opinions are all my own fault