This is the mail archive of the ecos-discuss@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: CS8900 Ethernet Device Driver in EDB7xxx


honda@itri.org.tw wrote:
> 
> Hello,
>      In the subroutine edb7xxx_cs8900_init of file if_edb7xxx.c, the code
> under the comment // Fetch hardware address is shown below:
> 
>           #if defined(CYGPKG_REDBOOT) && \
>               defined(CYGSEM_REDBOOT_FLASH_CONFIG) && \
>               !defined(CYGSEM_ARM_EDB7XXX_SET_ESA)
>               flash_get_config("edb7xxx_esa", enaddr, CONFIG_ESA);
>           #else
>               for (i = 0;  i < ETHER_ADDR_LEN;  i += 2) {
>                   unsigned short esa_reg = get_reg(PP_IA+i);
>                   enaddr[i] = esa_reg & 0xFF;
>                   enaddr[i+1] = esa_reg >> 8;
>               }
>           #endif
> 
>      If I define CYGSEM_ARM_EDB7XXX_SET_ESA only and not CYGPKG_REDBOOT and
> CYGSEM_REDBOOT_FLASH_CONFIG,, the address enaddr will be filled by get_reg
> (...), so it won't be the value I set in the ConfigTool, is that right?

Yes, it must be a bug. That #else should be a:

#elif !defined(CYGSEM_ARM_EDB7XXX_SET_ESA)

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine
Come to the Red Hat TechWorld open source conference in Brussels!
Keynotes, techie talks and exhibitions    http://www.redhat-techworld.com/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]