Re: [ECOS] vrc437x virtual vector support

[Jonathan Larmour <jlarmour at redhat dot com>]

Motoya Kurotsu wrote:
> 
> Hi, all;
> 
> I'm looking at the latest code of vrc4373 platform. I have two points.
> 
> 1) I assume that the conditional branch by CYGSEM_HAL_VIRTUAL_VECTOR_DIAG
> is necesarry in hal_daig.c/hal_diag.h such like some other platforms.
> 
> 2) In plf_serial.c, I guess that cyg_hal_plf_serial_xxx functions
> should be enbraced by #ifndef CYGSEM_HAL_VIRTUAL_VECTOR_INHERIT_CONSOLE or
> #if CYGSEM_HAL_VIRTUAL_VECTOR_CLAIM_COMMS rather than
> #ifdef CYGSEM_HAL_VIRTUAL_VECTOR_SUPPORT according to the original meaning
> that applications use the ROM monitors resources. In other words,
> is it necessary that applications include the code of these functions?

There does seem to be something odd right now. In a fully virtual vectored
HAL, there should be no need for the current contents of hal_diag.c.
Instead the hal_diag.h should point straight at the hal_if functions in
hal/common's hal_if.c. I'm surprised adding that extra GDB mangling works
without things getting double mangled. Nick?

And by the looks of it, platforms should indeed be conditionalising on
CLAIM_COMMS really (although the bloat should be limited if selective
linking works for your target, which it does for mips). 

This is just HALs inheriting old code - previously the virtual vector
configuration was not as rich (it used to be all or nothing). Good point
anyway.

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine