This is the mail archive of the ecos-discuss@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: powerpc serial driver


Christoph Csebits wrote:
> 
> i am writing on a SCC UART driver for eCos, and
> derived it from the existing SMC driver.
> 
> i made some changes to get it working. here
> are the changes for the SMC driver.
> 
> i could not test it, not even compile it.
> ( i do not have a SMC serial port).
> 
> It concerns flushing the cache before
> flushing the device.

I'm not entirely sure about this. In this bit:

@@ -398,11 +401,11 @@
                         TxBD, 
                         CYGNUM_IO_SERIAL_POWERPC_QUICC_SMC_SMC1_TxNUM,
                         CYGNUM_IO_SERIAL_POWERPC_QUICC_SMC_SMC1_TxSIZE,
-                        &quicc_smc1_txbuf[0][0],
+                        (cyg_uint8
*)ALIGN_TO_CACHELINES(&quicc_smc1_txbuf[0][0], 32),

If quicc_smc1_txbuf isn't aligned, then it won't be
CYGNUM_IO_SERIAL_POWERPC_QUICC_SMC_SMC1_TxSIZE long any more.

Also, got a ChangeLog entry?

Jifl
-- 
Red Hat, Rustat House, Clifton Road, Cambridge, UK. Tel: +44 (1223) 271062
Maybe this world is another planet's Hell -Aldous Huxley || Opinions==mine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]