This is the mail archive of the ecos-discuss@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: flash ROM support for cq7750.


> It would be good to get this code into eCos, but it requires a copyright
> assignment. Can you read http://sources.redhat.com/fom/ecos?file=47 and
> fill in the assignment form, disclaimer, and post them to us?

OK. I'll send it soon.

>  
> > @@ -330,6 +331,8 @@
> >                  if (FLASH_BlankValue == state) {
> >                      break;
> >                  }
> > +
> > +               if((state & FLASH_Busy) == (*b_v & FLASH_Busy)) break;
> 
> I'm not sure about this change. While checking the toggle bit is also a
> valid test that the erase operation has completed, why would it be required
> if the flash isn't blanked? Should this even replace the test against
> FLASH_BlankValue?

I had not been sure about blank checking algorythm.
Some tests without my this patch show OK.
The added code isn't necesarry. 

+++++++++++++++++++++++++++++++++++++++++++
Koichi Nagsahima, R-lab Inc. (Tokyo, Japan)
E-mail: naga@r-lab.co.jp
+++++++++++++++++++++++++++++++++++++++++++


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]