This is the mail archive of the
ecos-discuss@sourceware.org
mailing list for the eCos project.
Re: Re: LPC2xxx patch for support of vectored interrupt controller
- From: Andrew Lunn <andrew at lunn dot ch>
- To: Hans Rosenfeld <rosenfeld at grumpf dot hope-2000 dot org>
- Cc: Andrew Lunn <andrew at lunn dot ch>, ecos-discuss at ecos dot sourceware dot org
- Date: Wed, 22 Aug 2007 13:12:16 +0200
- Subject: Re: [ECOS] Re: LPC2xxx patch for support of vectored interrupt controller
- References: <21907044.603801184047861289.JavaMail.servlet@kundenserver> <20070817140209.GA26081@grumpf.hope-2000.org> <20070817171322.GB26081@grumpf.hope-2000.org> <20070820151336.GA1125@grumpf.hope-2000.org> <20070822082451.GF31057@lunn.ch> <20070822084026.GA2126@grumpf.hope-2000.org> <20070822091803.GH31057@lunn.ch> <20070822095228.GD2126@grumpf.hope-2000.org> <20070822100626.GJ31057@lunn.ch> <20070822105132.GF2126@grumpf.hope-2000.org>
On Wed, Aug 22, 2007 at 12:51:32PM +0200, Hans Rosenfeld wrote:
> On Wed, Aug 22, 2007 at 12:06:26PM +0200, Andrew Lunn wrote:
> > I wanted to avoid _0 and _1 because it may make reader of the code
> > think they have the value of 0 and 1! If a reading is interested in
> > the value, using A and B makes the reader go looking for the actual
> > value, rather than assume they are 0 and 1.
>
> Yes, that was bad style on my part.
>
> > In the code i would replace 0 with CYGNUM_KERNEL_INTR_TEST_PRIO_A and
> > 1 with CYGNUM_KERNEL_INTR_TEST_PRIO_B, since the defaults set them to
> > these values.
>
> Maybe we should have CYGNUM_KERNEL_INTR_TEST_PRIO_C, too. The tests
> create three interrupts.
O.K.
Could your produce a patch which contains all these changes and a
ChangeLog entry in both the Kernel package and the HAL.
Thanks
Andrew
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss