This is the mail archive of the
ecos-discuss@sourceware.org
mailing list for the eCos project.
net/bsd_tcp code conditional on (__NetBSD__ || __OpenBSD__)
- From: Grant Edwards <grant dot b dot edwards at gmail dot com>
- To: ecos-discuss at sources dot redhat dot com
- Date: Wed, 7 Mar 2012 17:51:54 +0000 (UTC)
- Subject: [ECOS] net/bsd_tcp code conditional on (__NetBSD__ || __OpenBSD__)
I'm still working on clean up compiler warnings generated by gcc 4.6,
and all that's left is stuff under net/bsd_tcpip. There are variables
that are set in code that's compiled unconditionally, but only
referenced in code that's conditional on
#if defined(__NetBSD__) || defined(__OpenBSD__)
Does eCos ever build that code with either __NetBSD__ or __OpenBSD__
defined?
If not, just removing the variables would seem to be cleaner than
marking them with the "unused" attribute. [My guess is that the
compiler generates the same code either way, but I haven't verified
that.]
However, removing the variables rather than marking them unused will
probably mean a lot more work when it comes time to incorporate
updates from upstream (which we all hope will happen someday when
"somebody else" has time to work on it).
So: remove or mark as "unused"?
--
Grant Edwards grant.b.edwards Yow! Jesus is my POSTMASTER
at GENERAL ...
gmail.com
--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss