This is the mail archive of the ecos-discuss@sourceware.org mailing list for the eCos project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Question about unused 'netmask' var in bootp_support.c

From: Grant Edwards <grant dot b dot edwards at gmail dot com>
To: ecos-discuss at sources dot redhat dot com
Date: Thu, 8 Mar 2012 15:03:01 +0000 (UTC)
Subject: [ECOS] Re: Question about unused 'netmask' var in bootp_support.c
References: <jir1ei$avu$1@dough.gmane.org> <0822c15222481048a63b52ad52708ae1@cg.fzd.de>

On 2012-03-08, Lange, Bert <b.lange@hzdr.de> wrote:
> Hello Edward,
>
>> Can I just remove the declaration of netmask at line 452, and remove
>> line 484 entirely?  Or is this an actual bug because netmask is
>> supposed to be used for something?

> I would remove it.

That's what I've decided to do.

I'm also addressing similar warnings in other files.

Variables that are never referenced at all are being removed.
Variables that are set but then only referenced in conditionally
compiled code are being declared with gcc's "unused" attribute.

-- 
Grant Edwards               grant.b.edwards        Yow! Did YOU find a
                                  at               DIGITAL WATCH in YOUR box
                              gmail.com            of VELVEETA?


-- 
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss

References:
- Question about unused 'netmask' var in bootp_support.c
  - From: Grant Edwards
- RE: Question about unused 'netmask' var in bootp_support.c
  - From: Lange, Bert

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]