This is the mail archive of the ecos-discuss@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Typo in assert error message causing confusion?


Daniel,

I think it is printing the assertion, not the failure.

It would be clearer if it printed:

Assertion "data pointer NNN is valid" failed

But it might be consistent with standard practice. I am not sure.

Mike



On Oct 1, 2013, at 3:01 AM, Daniel Zebralla <daniel.zebralla@zebralla-it.de> wrote:

>> From /host/infra/cyg_ass.h as well as /host/infra/cyg/infra/cyg_ass.h:
> 
> # define CYG_CHECK_DATA_PTRC( _ptr_ )                   \
>         CYG_MACRO_START                                \
>         if ( !cyg_check_data_ptr((void *)(_ptr_)))     \
>             CYG_ASSERT_DOCALL("data pointer (" #_ptr_ ") is valid");\
>         CYG_MACRO_END
> 
> # define CYG_CHECK_FUNC_PTRC( _ptr_ )                       \
>         CYG_MACRO_START                                    \
>         if ( !cyg_check_func_ptr((void (*)(void))(_ptr_))) \
>             CYG_ASSERT_DOCALL("function pointer (" #_ptr_ ") is valid"); \
>         CYG_MACRO_END
> 
> As I understand, CYG_ASSERT_DOCALL is triggered when the checked data or
> function pointer is invalid. The printed message however indicates that the
> checked pointer is valid. Is this an error or am I misunderstanding the
> usage of CYG_ASSERT_DOCALL here?
> 
> Thanks for clarification!
> 
> 
> 
> --
> View this message in context: http://sourceware-org.1504.n7.nabble.com/Typo-in-assert-error-message-causing-confusion-tp245807.html
> Sent from the Sourceware - ecos-discuss mailing list archive at Nabble.com.
> 
> -- 
> Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
> and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss
> 


--
Before posting, please read the FAQ: http://ecos.sourceware.org/fom/ecos
and search the list archive: http://ecos.sourceware.org/ml/ecos-discuss


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]