This is the mail archive of the
ecos-maintainers@sourceware.org
mailing list for the eCos project.
Re: at91sam7s patch for PIT EFC PMC all in one...
- From: John Dallaway <john at dallaway dot org dot uk>
- To: Oliver Munz <munz at speag dot ch>
- Cc: eCos Maintainers <ecos-maintainers at ecos dot sourceware dot org>
- Date: Fri, 03 Jul 2009 13:36:09 +0100
- Subject: Re: at91sam7s patch for PIT EFC PMC all in one...
Hi Oliver
Andrew Lunn has forwarded your revised patch to me. It was rejected by
the mailing list for some reason.
I note that Kasim Malla is mentioned as a contributor. Is Kasim Malla
another employee of Schmid & Partner Engineering AG? Please confirm.
John Dallaway
---- Original Message ----
Date: Tue, 16 Jun 2009 15:56:33 +0200
From: "oliver munz @ s p e a g" <munz@speag.ch>
To: Andrew Lunn <andrew@lunn.ch>
CC: ecos-patches@sourceware.org
Subject: Re: at91sam7s patch for PIT EFC PMC all in one...
Hi Andrew
The patch is working - nearly :-)... The only problem is in the function:
static __inline__ cyg_bool
flash_controller_is_ready(cyg_uint32 page)
{
cyg_uint32 fsr;
#ifdef AT91_MC_FMR1
if (page >= PAGE_AT_WHICH_WE_USE_THE_EFC1){
HAL_READ_UINT32(AT91_MC+AT91_MC_FSR1, fsr);
} else
#endif
HAL_READ_UINT32(AT91_MC+AT91_MC_FSR, fsr);
return (fsr & AT91_MC_FSR_FRDY ? true : false);
}
In Your patch this function used both times AT91_MC+AT91_MC_FSR...
I did a new .diff, adding an other little change to
packages/hal/arm/at91/at91sam7sek/current/cdl/hal_arm_at91sam7sek.cdl
Regards
Oliver
[ snip ]