This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: Typo fix for nec_upd985xx USB device
- From: Jonathan Larmour <jifl at eCosCentric dot com>
- To: David Smith <dsmith at redhat dot com>
- Cc: ecos-patches at sources dot redhat dot com, Bart Veer <bartv at eCosCentric dot com>
- Date: Sat, 19 Oct 2002 06:08:19 +0100
- Subject: Re: Typo fix for nec_upd985xx USB device
- References: <1034961830.9437.99.camel@scooby.hsv.redhat.com>
David Smith wrote:
Here's a typo fix. If this isn't a typo, a comment needs to be added
that explains why the "*" (vs. the "&") is needed.
>
Note that Andrew Lunn (andrew.lunn@ascom.ch) originally found this.
If it's known to fix a problem it almost doesn't matter whether it was a
typo or not ;-). Bart's on vacation, so if you (or Andrew) can just
confirm that, I'll check it in.
Jifl
Index: devs/usb/nec_upd985xx/current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos/packages/devs/usb/nec_upd985xx/current/ChangeLog,v
retrieving revision 1.2
diff -u -p -r1.2 ChangeLog
--- devs/usb/nec_upd985xx/current/ChangeLog 23 May 2002 23:01:26 -0000 1.2
+++ devs/usb/nec_upd985xx/current/ChangeLog 18 Oct 2002 17:19:04 -0000
@@ -1,3 +1,7 @@
+2002-10-18 David Smith <dsmith@redhat.com>
+
+ * src/usbs_upd985xx.c (ep0_rx_dsr): Fixed a typo.
+
2001-09-20 Bart Veer <bartv@redhat.com>
* src/usbs_upd985xx.c (ep0_init):
Index: devs/usb/nec_upd985xx/current/src/usbs_upd985xx.c
===================================================================
RCS file: /cvs/ecos/ecos/packages/devs/usb/nec_upd985xx/current/src/usbs_upd985xx.c,v
retrieving revision 1.2
diff -u -p -r1.2 usbs_upd985xx.c
--- devs/usb/nec_upd985xx/current/src/usbs_upd985xx.c 23 May 2002 23:01:26 -0000 1.2
+++ devs/usb/nec_upd985xx/current/src/usbs_upd985xx.c 18 Oct 2002 17:19:05 -0000
@@ -1243,7 +1243,7 @@ ep0_rx_dsr(void)
// If we have received a control packet then any reset signals really
// will have come from the host and must be processed normally.
// Make sure that reset interrupts are no longer masked off.
- if (0 == (*USBS_IMR2 * IBUS_SWAP32(USBS_GSR2_URST))) {
+ if (0 == (*USBS_IMR2 & IBUS_SWAP32(USBS_GSR2_URST))) {
*USBS_IMR2 |= IBUS_SWAP32(USBS_GSR2_URST); FLUSH_IBUS();
usbs_upd985xx_gsr2_mask |= USBS_GSR2_URST;
}
--
eCosCentric http://www.eCosCentric.com/ <info@eCosCentric.com>
--[ "You can complain because roses have thorns, or you ]--
--[ can rejoice because thorns have roses." -Lincoln ]-- Opinions==mine