This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: pxa2x0 platform


> This is an impressive port - I've just inspected it and for the first time
> in a long time I don't have a single comment to make! Unless anyone has
> any other comments on it (you know who you are :-)) I'd like to check it
> straight in.

Some...

- some files have CRLF at the end, but the rest of eCos follows Unix 
convention

- in hal/arm/xscale/mpc50/current/include/hal_platform_setup.h I see 
init_mmu_cache_on, init_mmu_off but I have the feeling that this is 
PXA250-specific, not mpc50-specific. The same is true for init_sdram_cnt, 
althought this function needs board-specific values to do it's job.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]