This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Innovator patches


Attached (perhaps) is a set of small cleanup patches, based entirely on
jifl's feedback from the original post.  Specifically, these patches:
1) Add initial ChangeLog's to the hal/arm/arm9/innovator/current,
devs/eth/arm/innovator/current, and devs/flash/arm/innovator/current
directories
2) Changed DCSPRI_HAL_ROM_MLT to CYGPRI_HAL_ROM_MLT
3) Add the ethernet device to the Innovator target definition
4) include <string.h> instead of explicitly prototyping memset() in
innovator_misc.c.  (I really should change it in excalibur_misc.c as well --
would you like a totally untested patch containing that trivial change?)

As always, questions, comments, and snide remarks are welcome.

I am still trying to digest the comments about the eth driver.  I don't like
the fact that RedBoot prompts the user for the ESA/MAC address, which is
promptly ignored by the driver, so I want to fix that.  But I am confused by
jifl's suggestion that I "allow redboot dynamically to provide it, or use
compile time config, or an EEPROM, in that order".  My preference would be
to use the EEPROM on the board first, then redboot, then compile time
config.  Ideally, redboot shouldn't even prompt the user for it unless a
(cdl) switch gets thrown someplace first.  I am also a little concerned
about changes that would require that I tweak the lan91cxx and flexanet
drivers, since I have no way to test the flexanet (which is the only other
platform that uses the lan91cxx driver, hence the reason I based the
innovator driver on that one).

Enjoy!

--wpd

Attachment: innovator.patch2
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]