This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [APPROVE?] Stop ecosadmin.tcl calling 'cygpath' with empty path


John Dallaway wrote:
The appended patch accommodates the fact that the Cygwin 'cygpath' tool
does not like empty paths. "ecosadmin.tcl list" will therefore fail
under Windows at present. Approval requested for 2.0 branch.

Fine by me (with changelog), although I'd have thought it would be better not to call add_package at all (assuming this is the end of parse_arguments), i.e.


if { $ecosadmin::add_package != "" } {
set ecosadmin::component_repository [get_pathname_for_tcl $ecosadmin::component_repository]
}



I take it this means new release candidate then?


Jifl

--cut here--

--- /packages/ecosadmin.tcl.old	2003-01-29 12:45:02.000000000 +0000
+++ /packages/ecosadmin.tcl	2003-03-05 15:03:02.000000000 +0000
@@ -790,11 +790,11 @@
 # Take a cygwin32 filename such as //d/tmp/pkgobj and turn it into something
 # acceptable to Tcl, i.e. d:/tmp/pkgobj. There are a few other complications...

proc ecosadmin::get_pathname_for_tcl { name } {

-	if { $ecosadmin::windows_host } {
+	if { ( $ecosadmin::windows_host ) && ( $name != "" ) } {

 		# If there is no logical drive letter specified
 		if { [ string match "?:*" $name ] == 0 } {

# Invoke cygpath to resolve the POSIX-style path


--
eCosCentric    http://www.eCosCentric.com/    The eCos and RedBoot experts
--[ "You can complain because roses have thorns, or you ]--
--[  can rejoice because thorns have roses." -Lincoln   ]-- Opinions==mine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]