This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: edb7212 flash size bug
- From: Gary Thomas <gary at mlbassoc dot com>
- To: Jonathan Larmour <jifl at eCosCentric dot com>
- Cc: Jani Monoses <jani at iv dot ro>,eCos patches <ecos-patches at sources dot redhat dot com>
- Date: 27 Mar 2003 16:33:27 -0700
- Subject: Re: edb7212 flash size bug
- References: <20030327192431.681cb071.jani@iv.ro> <3E834868.5000204@eCosCentric.com>
On Thu, 2003-03-27 at 11:52, Jonathan Larmour wrote:
> Jani Monoses wrote:
> > Hi
> > this is a rediff/resend of a patch from August 2002
> > the edb7212 has 16Megs of flash but it's not contiguous
> > fi init -f overwrites redboot because it wraps after 8Megs.
> > the patch correctly sets the limits of the two blocks
> > sets the flash size to 16 in the linker script and changes an #if to #ifdef
> > to avoid a gcc warning
>
> I _would_ be happy to apply this, although I would have thought this would
> have been picked up in testing before, when we are all still in Red Hat.
> Gary, any opinions?
>
> I also note the patch doesn't have a ChangeLog, and omits to patch the
> .mlt file similarly (it's easy to guess how), but I can fix that up before
> it's committed if Jani doesn't get back to me before Gary does.
>
I think these patches are fine. Note that we were never able
to really test RedBoot on the 7211 hardware that Jani is making
changes for - we only had working 7212 boards - so that's probably
why we never saw this problem.
--
------------------------------------------------------------
Gary Thomas |
MLB Associates | Consulting for the
+1 (970) 229-1963 | Embedded world
http://www.mlbassoc.com/ |
email: <gary at mlbassoc dot com> |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------