This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: edb7212 flash size bug


On Thu, 2003-03-27 at 16:43, Jonathan Larmour wrote:
> Gary Thomas wrote:
> > On Thu, 2003-03-27 at 11:52, Jonathan Larmour wrote:
> > 
> >>Jani Monoses wrote:
> >>
> >>>Hi
> >>>this is a rediff/resend of a patch from August 2002
> >>>the edb7212 has 16Megs of flash but it's not contiguous
> >>>fi init -f overwrites redboot because it wraps after 8Megs.
> >>>the patch correctly sets the limits of the two blocks
> >>>sets the flash size to 16 in the linker script and changes an #if to #ifdef
> >>>to avoid a gcc warning
> >>
> >>I _would_ be happy to apply this, although I would have thought this would 
> >>have been picked up in testing before, when we are all still in Red Hat. 
> >>Gary, any opinions?
> >>
> >>I also note the patch doesn't have a ChangeLog, and omits to patch the 
> >>.mlt file similarly (it's easy to guess how), but I can fix that up before 
> >>it's committed if Jani doesn't get back to me before Gary does.
> >>
> > 
> > 
> > I think these patches are fine.  Note that we were never able
> > to really test RedBoot on the 7211 hardware that Jani is making
> > changes for - we only had working 7212 boards - so that's probably
> > why we never saw this problem.
> 
> Exactly :-). This is the 7212 we're talking about. Hence my query.

His patches seem to deal with the older 7211 which has a quite different
memory map/layout.  I don't see them affecting the 7212 which we tested
"to death".

-- 
------------------------------------------------------------
Gary Thomas                 |
MLB Associates              |  Consulting for the
+1 (970) 229-1963           |    Embedded world
http://www.mlbassoc.com/    |
email: <gary at mlbassoc dot com>  |
gpg: http://www.chez-thomas.org/gary/gpg_key.asc
------------------------------------------------------------


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]