This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: strata.h fix


Sorry about that !
I'm preparing the patch right now with more fixes.
cyg/infra/cyg_type.h is needed by flash_dev.h but not included.
I had this change in io/flash but forgot about it.
Other drivers which include flash_dev (indirectly) include cyg_type
before that.
So I was going to send the patch but what is the preference?
Include cyg_type from strata before flash_dev or include it from
flash_dev where cyg_int32 and friends are used?

Jani.

> Jonathan Larmour <jifl at eCosCentric dot com> writes:
> 
> > Jani Monoses wrote:
> > > Hi
> > > the strata header defines FLASHWORD for different values of flash
> > > width and number of devices.This smae code is already found in
> > > io/flash/flash_dev.h So include that instead.It's simpler and
> > > besides fixes the case of width=16 bit and nodevs =4 which was not
> > > checked for but devs==2 was checked twice.Besides the strata
> > > version uses plain C types instead of cyg_XXX names.I defined
> > > INTERLEAVE to be DEVICES and flash_t to flash_data_t to not have
> > > to modify the rest of the strata code for now.I can do that to and
> > > have the same names is all drivers to keep confusion level lower.
> > 
> > It's not important, although I'd apply such a patch if you sent it.
> > 
> > > Oh and for some reason I though we were in 2002 but a quick
> > > googling reveals that this is no longer the case. So I modified
> > > the previous changelog entry's date.All the flash patches I sent
> > > yesterday and today have this....inaccuracy.
> > 
> > Oops!
> > 
> > All applied. Thanks!
> > 
> 
> There appears to be something wrong with this patch. Configuring and
> building RedBoot for the iq80321 I get a whole slew of compile errors
> in the strata flash driver. All centered around flash_data_t.
> 
> I've not investigated very deeply, I'll leave it to Jani to
> investigate and propose a solution.
> 
> 
> -- 
> Nick Garnett                    eCos Kernel Architect
> http://www.ecoscentric.com/     The eCos and RedBoot experts
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]