This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: EB40a evaluation LEDs


On Wed, Jun 11, 2003 at 01:47:38PM +0200, Øyvind Harboe wrote:
> I've been toying with LEDs and made the following fixes
> to LEDs. Checking th EB40a manual, the circuit diagram is correct
> and the documentation is incorrect on LEDs.
> 
> Added pushbutton defines while I was at it.
> 
> Also, this is my second attempt at submitting a well-formed
> patch :-)

Better,.....

but,

1) Your mailer manged the patch. Some of the long lines have been
   wrapped onto the next line. This causes the patch to fail. Its
   safer to send the patch as an attachment.

2) You created three patches in different directories and then stuck
   them together. This does not work since i only run patch once in
   one directory. I generally generate patches from the packages
   directory. ie the patch attached i generated thus:

cvs diff hal/arm/at91/eb40a/ > ~.eb40a.diff

> +// these PIOs double as TCLK1, TIOA1, TIOB1, TCLK2 respectively.
> +#define EB40A_LED5 0x00010000
> +#define EB40A_LED6 0x00020000
> +#define EB40A_LED7 0x00040000
> +#define EB40A_LED8 0x00080000
> +// these io pins are for the LEDs.
> +#define EB40A_LED1 0x00000008
> +#define EB40A_LED2 0x00000010
> +#define EB40A_LED3 0x00000020
> +#define EB40A_LED4 0x00000040

I changed the order of these, so that LED1 comes first....

While i was at it, i also fixed one of the compiler warnings. One
still remains.

I don't have the hardware to test this on, but it does at least
compile.

      Andrew

Attachment: eb40a.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]