This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Added unicast support to SNTP client


Andrew,

1) I intended the NTP_UDP_PORT constant to be used by
the caller of cyg_sntp_set_servers() when setting up
the sockaddr structures.  But I see your point about
using the getservbyname approach.  I will remove the
constant definition and submit another patch.

2) I will look into enhancing the test program and
updating the docs.

3) I mangled my email address on purpose for spam
protection.  I figured there was enough info there to
derive the real address.  If this is a problem then
perhaps I'll change it to my posting address, but
there is no guarantee that I would ever respond to it.

Thanks for the review,

Dan

--- Andrew Lunn <andrew@lunn.ch> wrote:
> On Thu, Oct 02, 2003 at 03:41:00PM -0700, Dan
> Jakubiec wrote:
> > Hi Gary,
> > 
> > No problem: I've attached the same SNTP patch, but
> > this time using 'cvs diff -u'.
> 
> Index: packages/net/sntp/current/ChangeLog
>
===================================================================
> RCS file:
> /cvs/ecos/ecos-opt/net/net/sntp/current/ChangeLog,v
> retrieving revision 1.6
> diff -u -r1.6 ChangeLog
> --- packages/net/sntp/current/ChangeLog	21 May 2003
> 14:03:36 -0000	1.6
> +++ packages/net/sntp/current/ChangeLog	2 Oct 2003
> 22:36:41 -0000
> @@ -1,3 +1,9 @@
> +2003-09-29  Dan Jakubiec 
> <firstname.lastname@systech.com>
>                            
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> You need to set up emacs to fill in your email
> address correctly.
> This has also been committed to CVS!
> 
> +
> +	* src/sntp.c: Added support for SNTP unicast mode.
> +	* src/sntp.h: Added support for SNTP unicast mode.
> +	* src/sntp.cdl: Added support for SNTP unicast
> mode.
> +
>  2003-05-19  Andrew Lunn  <andrew.lunn@ascom.ch>
>  
> +/* General Definitions */
> +#define NTP_UDP_PORT            123
> +
> 
> I don't like this. Its not used anywhere in your
> code and you should
> be using getaddrinfo, or getservbyname. Both know
> about ntp.
> 
> Please could you also extend the test program. What
> i suggest it to
> extend the current test program so that after its
> finished the current
> test it sets the time back to the epoc and then
> sends a query to the
> server in the bootp record. After 20 seconds, sanity
> check the time in
> the same way the current test does.
> 
> Please could you also update the SGML documentation.
> 
> 
>        Thanks
>           Andrew


__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]