This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: Added RTL8201 PHY support to ks32c5000 ethernet driver
- From: Roland Caßebohm <roland dot cassebohm at visionsystems dot de>
- To: Gary Thomas <gary at mlbassoc dot com>
- Cc: eCos patches <ecos-patches at sources dot redhat dot com>
- Date: Mon, 10 Nov 2003 18:17:12 +0100
- Subject: Re: Added RTL8201 PHY support to ks32c5000 ethernet driver
- References: <200310091815.14225.roland.cassebohm@visionsystems.de> <1065716413.1884.1850.camel@hermes>
On Donnerstag, 9. Oktober 2003 18:20, Gary Thomas wrote:
> On Thu, 2003-10-09 at 10:15, Roland Caßebohm wrote:
> > 2003-10-09 Roland Cassebohm <roland.cassebohm@visionsystems.de>
> >
> > * src/rtl8201.c: New file. Added RTL8201 PHY support.
> > * cdl/ks32c5000_eth.cdl: CDL to allow configuration of the above.
>
> Two things:
> 1. Could you please try to use the PHY framework instead of
> adding this [somewhat duplicated] code?
Maybe this is also a little mistake, I don't have written the PHY
infrastructure of the driver itself, which is much older then the new
generic one. The driver has already implementations for three different
PHY devices. The only thing I added is another PHY device.
I think it would be still better to rewrite the whole driver to use the
new generic PHY infrastructure and I would be lucky if I would find time
to do that, but maybe for now it should be enough to integrate my patch?
Best regards,
Roland
--
___________________________________________________
VS Vision Systems GmbH, Industrial Image Processing
Dipl.-Ing. Roland Caßebohm
Aspelohe 27A, D-22848 Norderstedt, Germany
http://www.visionsystems.de
___________________________________________________