This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch for smsc lan91cxx ethernet driver


On Mon, Dec 29, 2003 at 02:47:10PM +0100, Uwe Kindler wrote:
> Hello,
> 
> because the interrupt priority of the EDOSK-2674 board is configurable (8
> priorities from 0 - 7) it is necessary to provide an interrupt priority
> value when creating the lan91cxx interrupt with cyg_drv_interrupt_create. If
> the platform provides the interrupt priority with the new value
> CYGNUM_DEVS_ETH_SMSC_LAN91CXX_INT_PRIO, then this should be used for
> interrupt priority.
> 
> I would like to suggest the following patch.

I think using CDL is a nicer solution. I've made the interrupt
priority a CDL option with a default value of 3 so we retain the
original behavior. You can then override it as needed. 

In the hardware specific part of the ethernet driver put something like

   requires CYGNUM_DEVS_ETH_SMSC_LAN91CXX_INT_PRIO==4

The CDL engine will then override the default value with 4.

Please could you test this patch and let me know how it goes.

       Andrew

Attachment: smsc.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]