This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: at91 cdl refactoring , settable baudrate from redboot
On Wed, Feb 18, 2004 at 03:50:04PM +0100, Daniel N?ri wrote:
> Jani Monoses <jani@iv.ro> writes:
>
> > It was 'calculated' in the variants so I did not change that.
> ^^^^^^^^
>
> You meant to say "platform HALs" there, I assume. Defining it as
> "calculated" in the platform is perfectly valid (for boards with fixed
> clock rates).
>
> > The patch I made did not change the default for any platform did it?
>
> Well, yes, indirectly.
>
> > BTW we are using our custom at91 variant at a different speed so we
> > just changed the cdl to have a default_value instead of calculated,
>
> This is exactly my point; if you have to modify the variant HAL to
> account for your custom board, then we have a problem.
<Disclaimer>I don't know these devices at all </disclaimer>
>From what i can gather all these devices are normally run at the same
speed. So i think i would put the clock rate into the variant. But i
would set it using a default_value.
If some platform is running the clock at a different rate, all it then
needs to do in the platform HAL is put in a requires statement. The
CDL engine will then override the default_value in the variant CDL
with the correct value from the platform HAL.
Andrew