This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: at91 cdl refactoring , settable baudrate from redboot


> 
> I'm afraid I don't agree with some of this patch. This CDL may appear
> to be common to all the platforms, but only because they are all
> similar Atmel eval boards. The variant HAL has to be able to also deal
> with custom AT91 based boards dissimilar from the Atmel eval boards.

Ok, it seems I was a bit overzealous :) The baudrate change which
triggered the whole patch affected some configs and I thought that
instead of changing them in every cdl I'll put them in common so custom
at91s need not be changed too, figuring that future changes might be of
the same type i.e affect all platforms in the same way. For official
targets conditional configs can be introduced for startup type if
necessary (like I did with the clock speed which differed for one of
the platforms).
The remaining parts of the cdls were also all similar except the
strings used for target name and various file names otherwise I would
have extracted those parts too :)

Jani


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]