This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: Clean warning on quicc2_diag.c
- From: Andrew Lunn <andrew at lunn dot ch>
- To: sebastien Couret <sebastien dot couret at elios-informatique dot fr>
- Cc: ecos-patches at sources dot redhat dot com
- Date: Thu, 18 Mar 2004 16:24:00 +0100
- Subject: Re: Clean warning on quicc2_diag.c
- References: <MELELIOSHyAcarW24fA00000015@melelios.dmz.elios-informatique.fr>
On Thu, Mar 11, 2004 at 11:27:52AM +0100, sebastien Couret wrote:
> Compiler is issuing a warning 'larged integer implicitly truncated to
> unsigned byte type' at ligne 407 of quicc2_diag.c (1.4).
>
> In fact 0xFFFF is assigned to a smc_smce which is a CYG_BYTE type ... that
> means a byte.
> (infra/current/include/cyg_type.h:typedef cyg_uint8 CYG_BYTE;)
>
> Here's the patch :
> diff -a -w -u -r 1.4 quicc2_diag.c
> --- 1.4/quicc2_diag.c Thu Mar 11 10:30:47 2004
> +++ quicc2_diag.c Thu Mar 11 11:08:19 2004
> @@ -404,7 +404,7 @@
> regs->smc_smcmr = 0x4823;
>
> // Clear events
> - regs->smc_smce = 0xFFFF;
> + regs->smc_smce = 0xFF;
> regs->smc_smcm = SMCE_Rx;
>
> // Init channel
Hi Sebastien
Please could you submit this patch again. This time include a
ChangeLog entry and make the patch relative to the packages
directory. Its not clear which quicc2_diag.c this is supposed to be
applied to. There are 2 of them.
Thanks
Andrew