This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: New port for ARM Industrial Modules AIM 711
- From: Andrew Lunn <andrew at lunn dot ch>
- To: roland dot cassebohm at visionsystems dot de
- Cc: eCos Patches <ecos-patches at ecos dot sourceware dot org>
- Date: Tue, 6 Apr 2004 18:28:19 +0200
- Subject: Re: New port for ARM Industrial Modules AIM 711
Hi Roland
I took a quick look at another file as well.
rtl8201.c:
It needs a copyright header.
The DEBUG_PRINTF macro is not used. Delete it.
There is more code inside #if 0 which forces the PHY to different
rates and duplex's. Looks like it should be controlled from CDL. I
would turn cdl_option CYGPKG_DEVS_ETH_ARM_KS32C5000_PHY_RTL8201 into a
cdl_package and put the options inside it.
do_autonegotation seems to be an unused variable.
Andrew