This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New port for ARM Industrial Modules AIM 711


Hi Roland

I took a quick look at another file as well.

rtl8201.c:

It needs a copyright header.

The DEBUG_PRINTF macro is not used. Delete it.

There is more code inside #if 0 which forces the PHY to different
rates and duplex's. Looks like it should be controlled from CDL. I
would turn cdl_option CYGPKG_DEVS_ETH_ARM_KS32C5000_PHY_RTL8201 into a
cdl_package and put the options inside it.

do_autonegotation seems to be an unused variable.

       Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]