This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: Typo and new flash device
- From: Andrew Lunn <andrew at lunn dot ch>
- To: Bob Koninckx <bob dot koninckx at o-3s dot com>
- Cc: eCos Patches <ecos-patches at ecos dot sourceware dot org>
- Date: Sun, 11 Apr 2004 13:49:13 +0200
- Subject: Re: Typo and new flash device
- References: <1081459693.26832.1.camel@pc-002>
On Thu, Apr 08, 2004 at 11:28:13PM +0200, Bob Koninckx wrote:
> patch corrects a typo and adds support for amd29pl160 top boot block
> devices
>
> Regards,
> Bob
Hi Bob.
The first part of the patch looks fine and i've committed it. But:
> +2004-04-08 Bob Koninckx <bob.koninckx@o-3s.com>
> + * src/powerpc_ec555_flash.c: Adapted flash start address to new memory
> + map. Up to 16 MB of flash is now supported.
> +
> 2002-04-24 Bob Koninckx <bob.koninckx@mech.kuleuven.ac.be>
>
> * New package.
>
> //===========================================================================
> Index: powerpc/ec555/current/src/powerpc_ec555_flash.c
> ===================================================================
> RCS file: /cvs/o3s/software/ecos/packages/devs/flash/powerpc/ec555/current/src/powerpc_ec555_flash.c,v
> retrieving revision 1.1.1.1
> retrieving revision 1.2
> diff -u -5 -r1.1.1.1 -r1.2
> --- powerpc/ec555/current/src/powerpc_ec555_flash.c 7 Jun 2003 09:02:13 -0000 1.1.1.1
> +++ powerpc/ec555/current/src/powerpc_ec555_flash.c 8 Apr 2004 20:50:58 -0000 1.2
> @@ -51,14 +51,14 @@
> //==========================================================================
>
> //--------------------------------------------------------------------------
> // Device properties
>
> -#define CYGNUM_FLASH_INTERLEAVE (2)
> -#define CYGNUM_FLASH_SERIES (1)
> -#define CYGNUM_FLASH_WIDTH (16)
> -#define CYGNUM_FLASH_BASE (0x00800000)
> +#define CYGNUM_FLASH_INTERLEAVE (2)
> +#define CYGNUM_FLASH_SERIES (1)
> +#define CYGNUM_FLASH_WIDTH (16)
> +#define CYGNUM_FLASH_BASE (0x02000000)
Doesn't moving this base address mean a hardware change? Is this
something specific to a custom board you have, or is this also true
for the generic board?
Andrew