This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
One of the places in bootp_support.c that used to return false is now returning true. I don't know if you intended to make that change. You also missed that the close(s6) call in dhcp_prot.c was moved (it's in the wrong place). Attached updated patch. Jay -----Original Message----- From: Andrew Lunn [mailto:andrew@lunn.ch] Sent: Sunday, April 11, 2004 4:27 AM To: Jay Foster Cc: ecos-patches@sources.redhat.com Subject: Re: DHCP/BOOTP-Fix Socket Resource Leak On Thu, Apr 08, 2004 at 01:52:34PM -0700, Jay Foster wrote: > The attached patch fixes a socket resource leak with the DHCP/BOOTP code. > The problem could also lead to an orphaned socket listening on UDP port 0. Instead of adding all those close calls i put in goto's. It should produce slighly smaller code. I also fixed a few compiler warnings about the size of infinite. Andrew
Attachment:
dhcp_close2.pat
Description: Binary data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |