This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
bsd_tcpip patch for false positive assert
- From: Øyvind Harboe <oyvind dot harboe at zylin dot com>
- To: ecos-patches at sources dot redhat dot com
- Date: Tue, 20 Apr 2004 09:55:00 +0200
- Subject: bsd_tcpip patch for false positive assert
- Organization: Zylin AS
Did I get this right?
--
Øyvind Harboe
http://www.zylin.com
Index: current/ChangeLog
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/ChangeLog,v
retrieving revision 1.44
diff -u -r1.44 ChangeLog
--- current/ChangeLog 5 Apr 2004 16:23:53 -0000 1.44
+++ current/ChangeLog 20 Apr 2004 07:45:34 -0000
@@ -1,3 +1,7 @@
+2004-04-20 Oyvind Harboe <oyvind.harboe@zylin.com>
+
+ * src/ecos/timeout.c: remove assert that yielded false positives.
+
2004-03-30 Horst Kronstorfer <horst.kronstorfer@frequentis.com>
* src/sys/kern/uipc_mbuf.c
Index: current/src/ecos/timeout.c
===================================================================
RCS file: /cvs/ecos/ecos-opt/net/net/bsd_tcpip/current/src/ecos/timeout.c,v
retrieving revision 1.3
diff -u -r1.3 timeout.c
--- current/src/ecos/timeout.c 12 May 2003 11:03:06 -0000 1.3
+++ current/src/ecos/timeout.c 20 Apr 2004 07:45:41 -0000
@@ -402,8 +402,10 @@
for (e = timeouts; e; e = e->next) {
if (e->delta) {
CYG_ASSERT( e->delta >= last_delta, "e->delta underflow" );
- CYG_ASSERT( last_set_time + e->delta + 1000 > now,
- "Recorded alarm not in the future!" );
+ // The alert below may yields false positives since on slow CPU's
+ // it might simply be a matter of not enough CPU to process everything
+ // CYG_ASSERT( last_set_time + e->delta + 1000 > now,
+ // "Recorded alarm not in the future!" );
if ( e->delta < delta )
delta = e->delta;
} else {