This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: workspace_size unused
- From: Gary Thomas <gary at mlbassoc dot com>
- To: Andrew Lunn <andrew at lunn dot ch>
- Cc: Jani Monoses <jani at iv dot ro>, ecos-patches at sources dot redhat dot com
- Date: Fri, 28 May 2004 09:54:15 -0600
- Subject: Re: workspace_size unused
- Organization: MLB Associates
- References: <20040528182914.322c7a48.jani@iv.ro> <20040528155128.GT32174@lunn.ch>
On Fri, 2004-05-28 at 09:51, Andrew Lunn wrote:
> On Fri, May 28, 2004 at 06:29:14PM +0300, Jani Monoses wrote:
> > Hello
> >
> > if nobody objects I'll commit this on Monday
> > workspace_size seems to be a leftover from old code.
>
> I thought somebody had submitted a patch like this before. So either
> it got lost before being committed, or there was a reason not to
> commit it.
>
> Gary should OK this patch.
Fine with me - as long as it has gone truly unused :-)
>
> Andrew
>
> >
> > Jani
> >
>
> > --- orig/packages/redboot/current/include/redboot.h
> > +++ mod/packages/redboot/current/include/redboot.h
> > @@ -89,7 +89,6 @@
> > EXTERN bool valid_address(unsigned char *addr);
> > EXTERN void cyg_plf_memory_segment(int seg, unsigned char **start, unsigned char **end);
> > EXTERN unsigned char *workspace_start, *workspace_end;
> > -EXTERN unsigned long workspace_size;
> >
> > // Data squirreled away after a load operation
> > EXTERN unsigned long entry_address;
> >
> >
> > --- orig/packages/redboot/current/src/main.c
> > +++ mod/packages/redboot/current/src/main.c
> > @@ -286,18 +286,15 @@
> > #ifdef CYGMEM_SECTION_heap1
> > workspace_start = (unsigned char *)CYGMEM_SECTION_heap1;
> > workspace_end = (unsigned char *)(CYGMEM_SECTION_heap1+CYGMEM_SECTION_heap1_SIZE);
> > - workspace_size = CYGMEM_SECTION_heap1_SIZE;
> > #else
> > workspace_start = (unsigned char *)CYGMEM_REGION_ram;
> > workspace_end = (unsigned char *)(CYGMEM_REGION_ram+CYGMEM_REGION_ram_SIZE);
> > - workspace_size = CYGMEM_REGION_ram_SIZE;
> > #endif
> >
> > if ( ram_end < workspace_end ) {
> > // when *less* SDRAM is installed than the possible maximum,
> > // but the heap1 region remains greater...
> > workspace_end = ram_end;
> > - workspace_size = workspace_end - workspace_start;
> > }
> >
> > // Nothing has ever been loaded into memory
--
Gary Thomas <gary@mlbassoc.com>
MLB Associates