This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: vnc and lwip


Andrew Lunn wrote:
On Fri, May 28, 2004 at 06:33:55PM +0300, Jani Monoses wrote:

Since lwip has a network.h header for compatibility with the other stacks
this can be applied.Will do so if nobody objects.

Excuse my unfamiliarity but shouldn't lwip use the "standard" header locations for its API headers? Or is this something in the upstream main lwip distribution.


Personally I dislike <network.h> when the new POSIX standard has a standardised layout for the BSD sockets API. i.e. <sys/socket.h> etc.

Jifl


Looks good to me. Don't forget a ChangeLog entry as well.


Andrew


Jani

--- orig/packages/net/vnc_server/current/src/vnc-server.c
+++ mod/packages/net/vnc_server/current/src/vnc-server.c
@@ -58,16 +58,7 @@
#include <stdlib.h>
#include <vnc-server.h>

-#ifdef CYGPKG_NET
-/* eCos (BSD stack) include */
#include <network.h>
-#else
-/* eCos (lwIP stack) include */
-#include <lwip/sys.h>           /* lwIP stack includes */
-#define LWIP_COMPAT_SOCKETS 1
-#include <lwip/sockets.h>
-#include <lwip/inet.h>
-#endif





--
eCosCentric    http://www.eCosCentric.com/    The eCos and RedBoot experts
--["No sense being pessimistic, it wouldn't work anyway"]-- Opinions==mine


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]