This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: at91 watchdog on eb42
- From: davarn at free dot fr
- To: Nick Garnett <nickg at ecoscentric dot com>
- Cc: ecos-patches at ecos dot sourceware dot org,ecos-maintainers at ecos dot sourceware dot org
- Date: Mon, 2 Aug 2004 14:02:16 +0200
- Subject: Re: at91 watchdog on eb42
- References: <1090845473.4104fb212a10b@imp5-q.free.fr> <m3hdruhfzi.fsf@xl5.calivar.com> <1091001934.41075e4ea029d@imp6-q.free.fr> <m3r7qwdzju.fsf@xl5.calivar.com> <1091172281.4109f7b959cff@imp5-q.free.fr> <m3pt69airj.fsf@xl5.calivar.com>
Hello,
The change is really the minimum, even if it is quite important.
Tis is due to the fact that on eb42 board, if Interrupt is used in init_hw, the
object is not already intialized so the attach function assert.
Moving it in the start function make the thing work, and does not change the
behavior at all.
To be closer to the original code, it is necessary to investigate object
intialization on eb42 board.
David ARNAUD
Selon Nick Garnett <nickg@ecoscentric.com>:
> davarn@free.fr writes:
>
> > Here is the patch from current cvs version.
> > A precision: ChangeLogvar is ChangeLog from hal/arm/at91/var/current
> > If the patch need an assignement, let me know, i will do it quickly.
> >
>
> This patch still seems to contain unnecessary and aparrently arbitrary
> changes to the source base. Any changes to support the new EB42
> watchdog should be kept to a minimum.
>
> Your sourcebase seems to be out of step with current anoncvs. Read the
> documentation in http://sources.redhat.com/ecos/patches.html about how
> to prepare a patch.
>
> --
> Nick Garnett eCos Kernel Architect
> http://www.ecoscentric.com/ The eCos and RedBoot experts
>
>