This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: CYG_MEMALLOC_FAIL() fix
- From: Andrew Lunn <andrew at lunn dot ch>
- To: ?yvind Harboe <oyvind dot harboe at zylin dot com>
- Cc: ecos-patches at sources dot redhat dot com
- Date: Mon, 27 Sep 2004 19:53:19 +0200
- Subject: Re: CYG_MEMALLOC_FAIL() fix
- References: <1096283959.2937.12.camel@famine>
> Index: current/ChangeLog
> ===================================================================
> RCS file: /cvs/ecos/ecos/packages/services/memalloc/common/current/ChangeLog,v
> retrieving revision 1.31
> diff -w -r1.31 ChangeLog
> 2a3,7
> > * No longer invoke cyg_memalloc_alloc_fail() on failure to
> > resize. It is not an out of memory condition.
Could you explain this better. On first reading of the comment if
understood it wrongly. Something like
* No longer invoke cyg_memalloc_alloc_fail() on failure to
resize. It is not an out of memory condition, it just means the current
memory allocation could not be expanded. realloc() will try allocating
a completelty new block of memory and only if that fails do we
have an out of memory condition.
Also your ChangeLog entry looks invalid. It does not appear to start
with the usual header of date, name, email address. Please also use
unified diffs, they are much easier for a human to read.
Thanks
Andrew