This is the mail archive of the
mailing list for the eCos project.
Re: eCos jffs2 garbage collection thread + fix
- From: Andrew Lunn <andrew at lunn dot ch>
- To: Per Hedblom <per dot hedblom at abem dot se>
- Cc: 'eCos Patches' <ecos-patches at ecos dot sourceware dot org>,'David Woodhouse' <dwmw2 at infradead dot org>
- Date: Thu, 2 Dec 2004 14:53:39 +0100
- Subject: Re: eCos jffs2 garbage collection thread + fix
- References: <20041114234059.F151037E46@smtp2-2-sn4.m-sp.skanova.net>
On Mon, Nov 15, 2004 at 12:40:55AM +0100, Per Hedblom wrote:
> I have spent some time implementing the garbage collect thread for jffs2 in
> eCos. I publish this as a version that is more complete than the current
> gcthread.c without promising anything more. It seams to work under the synt
> target tested with low, the same, and higher priority than a file system
> test thread. One major question is if the locking of the icache is correct.
I would probably move the mutex initialisation into jffs2_mount rather
than hide it inside the GC code. I missed it the first time i read the
code. The mutex does not belong to GC, it belongs more to the
cache. So put it there the linked list is initialised.
You also seem to of missed icache_evict() which needs locking.