This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PPP fix for Sprint wireless network


Gary Thomas <gary@mlbassoc.com> writes:

> On Fri, 2005-01-14 at 07:29 -0800, Matt Jerdonek wrote:
> > Hi Andrew,
> > 
> > No, I hadn't seen that patch before.  Thanks for
> > pointing it out to me.
> > 
> > The eCos PPP code is correct as it is today as I
> > interpret RFC 1662.  The Sprint network is definitely
> > where the problem is.  However, I didn't pursue
> > getting Sprint to fix the bug, because I didn't think
> > I'd be able to get a timely resolution.
> > 
> > When I was investigating this issue, I found that MS
> > Windows PCs are able to connect into Sprint without an
> > issue.  After analyzing the traces, I found that
> > Windows always sends the leading flag while eCos does
> > not.  After changing eCos, I was able to connect.  
> > 
> > I don't think we'd introduce any issues by sending
> > back-to-back flags.  According to RFC 1662:
> > "Two consecutive Flag Sequences constitute an empty
> > frame, which is silently discarded, and not counted as
> > an FCS error."  (Section 3.1)
> > 
> > In any case, I won't be upset if you choose to not
> > commit this patch.  I was just trying to save someone
> > else the time it took me to figure this out.
> 
> I would think it acceptable to have this behaviour if the
> patch included some CDL to enable it (and it was off by default)

I agree. When it was just the one example, there was little reason to
put it into the repository. Now we have two instances of this, and we
can probably expect more to pop up. So a configuration option to
enable it seems a reasonable thing to do.

-- 
Nick Garnett                                          eCos Kernel Architect
http://www.ecoscentric.com                     The eCos and RedBoot experts
Besuchen Sie uns vom 22.-24.02.05 auf der Embedded World 2005, Stand 11-124
Visit us at Embedded World 2005, NÃrnberg, Germany, 22-24 Feb, Stand 11-124


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]