This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: default_route set to 0 during cyg_ppp_up


First let me apologize because it appears as if the
patch we submitted is the source of the problem.

The patch was submitted to allow ACCM to be
negotiated.  The suspect line of code was moved to
allow the ACCM values to be setup before the LCP was
initialized.

Instead of moving the line of code back to its
original spot (which would break the patch), can we
instead remove the wo initialization within
cyg_ppp_options_install into ipcp_init.c?

Maintainers -- do you want me to submit a patch on
this?

-- Matt



--- Per Hedblom <per.hedblom@abem.se> wrote:
> Hi,
> I updated my eCos to the latest CVS and found that
> the PPP connection
> doesn't work any more. I get the "No route to host"
> error when I start ftp.
> 
> I found that the ppp option default_route gets
> cleared during cyg_ppp_up and
> traced down the problem to the latest change of
> cyg_pppd_main  in pppd.c 
> 
> The structure ipcp_wantoptions is cleared in
> ipcp_init. Called in
> (*protp->init)(0);.
> 
> Without knowing why the call to
> cyg_ppp_options_install was moved I suggest
> that the call is moved back to its original
> position.
> /Per Hedblom
> 
> Index: pppd.c
>
===================================================================
> RCS file:
> /cvs/ecos/ecos-opt/net/net/ppp/current/src/pppd.c,v
> retrieving revision 1.5
> diff -u -w -b -b -B -p -r1.5 pppd.c
> --- pppd.c	7 Apr 2005 16:07:00 -0000	1.5
> +++ pppd.c	20 Apr 2005 12:38:04 -0000
> @@ -258,11 +258,11 @@ cyg_pppd_main(CYG_ADDRWORD
> arg)
>  
>      phase = PHASE_INITIALIZE;
>  
> -    cyg_ppp_options_install( ((struct tty
> *)arg)->options );
> -
>      for (i = 0; (protp = protocols[i]) != NULL;
> ++i)
>          (*protp->init)(0);
>  
> +    cyg_ppp_options_install( ((struct tty
> *)arg)->options );
> +
>      if (!ppp_available()) {
>  	option_error(no_ppp_msg);
>  	exit(1);
> 
> 
> 
> 

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]