This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: exec command in pc redboot


Andrew Lunn wrote:
> Attached is a patch from Ian Campbell which adds the exec command to
> Redboot on pc platforms. I've reworked the patch a bit.
> 
> ...
> 
> --- hal/i386/pc/current/cdl/hal_i386_pc.cdl
> +++ hal/i386/pc/current/cdl/hal_i386_pc.cdl
> 
> ...     
> 
> +            cdl_option CYGHWR_REDBOOT_I386_TRAMPOLINE_ADDRESS {
> +                display       "Provide the trampoline address into Linux"
> +                flavor        data
> +                default_value 0x7C000
> +                requires      CYGINT_HAL_I386_PCMB_SCREEN_SUPPORT

I don't think this requires is needed here.  exec works fine on headless
systems.  I've attached a patch to remove the requires (and add a
description as a bonus).

David Vrabel
-- 
David Vrabel, Design Engineer

Arcom, Clifton Road           Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK         Web: http://www.arcom.com/
%status
pending
%patch
Index: ecos-working/packages/hal/i386/arch/current/ChangeLog
===================================================================
--- ecos-working.orig/packages/hal/i386/arch/current/ChangeLog	2005-04-22 10:09:38.000000000 +0100
+++ ecos-working/packages/hal/i386/arch/current/ChangeLog	2005-04-22 11:57:56.000000000 +0100
@@ -1,3 +1,9 @@
+2005-04-22  David Vrabel  <dvrabel@arcom.com>
+
+	* cdl/hal_i386.cdl (CYGHWR_REDBOOT_I386_TRAMPOLINE_ADDRESS): Don't
+	require CYGINT_HAL_I386_PCMB_SCREEN_SUPPORT so we can use the exec
+	command on platforms without a screen.
+
 2005-04-21  David Vrabel  <dvrabel@arcom.com>
 
 	* src/i386_stub.c: Rename the local memcpy function to
Index: ecos-working/packages/hal/i386/arch/current/cdl/hal_i386.cdl
===================================================================
--- ecos-working.orig/packages/hal/i386/arch/current/cdl/hal_i386.cdl	2005-04-22 11:37:18.000000000 +0100
+++ ecos-working/packages/hal/i386/arch/current/cdl/hal_i386.cdl	2005-04-22 11:55:13.000000000 +0100
@@ -176,10 +176,12 @@
         compile -library=libextras.a redboot_linux_exec.c 
 
         cdl_option CYGHWR_REDBOOT_I386_TRAMPOLINE_ADDRESS {
-            display       "Provide the trampoline address into Linux"
+            display       "Address for the trampoline code"
             flavor        data
             default_value 0x7C000
-            requires      CYGINT_HAL_I386_PCMB_SCREEN_SUPPORT
+            description   "This is the address to where the trampoline code is
+                           copied.  The trampoline copies the image to its
+                           final location and jumps to its entry point."
         }
     }
 }

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]