This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
Re: Race conditions in serial_select
- From: Andrew Lunn <andrew at lunn dot ch>
- To: "Gaer, A." <Andreas dot Gaer at baslerweb dot com>
- Cc: 'Jay Foster' <jay at systech dot com>, 'Andrew Lunn' <andrew at lunn dot ch>,ecos-patches at ecos dot sourceware dot org
- Date: Tue, 21 Jun 2005 17:30:34 +0200
- Subject: Re: Race conditions in serial_select
- References: <850597605E79D21182830008C7A4B9CF36159B76@localhost>
On Tue, Jun 21, 2005 at 05:01:29PM +0200, Gaer, A. wrote:
> Hello!
>
> As the DSR IMHO shouldn't try to accquire the mutex lock anyway, I would
> guess that it is save to do the locking in the proposed way. But I must
> admit that I intended to do it exactly the other way around like it was done
> in all the other functions of the serial.c file, simply to keep the logic a
> bit consistent. Don't ask me why I got it wrong, I must have been completely
> blind that afternoon. Sorry.
>
> I can resend the patch with the locks swapped, if this is wanted.
Yes please. Could you also test it with the test case you used to find
the problem in the first place.
Thanks
Andrew