This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Race conditions in serial_select


On Tue, Jun 21, 2005 at 05:01:29PM +0200, Gaer, A. wrote:
> Hello!
> 
> As the DSR IMHO shouldn't try to accquire the mutex lock anyway, I would
> guess that it is save to do the locking in the proposed way. But I must
> admit that I intended to do it exactly the other way around like it was done
> in all the other functions of the serial.c file, simply to keep the logic a
> bit consistent. Don't ask me why I got it wrong, I must have been completely
> blind that afternoon. Sorry.
> 
> I can resend the patch with the locks swapped, if this is wanted.

Yes please. Could you also test it with the test case you used to find
the problem in the first place.
        
        Thanks
                Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]