This is the mail archive of the
ecos-patches@sources.redhat.com
mailing list for the eCos project.
RE: Race conditions in serial_select
- From: Jay Foster <jay at systech dot com>
- To: 'Andrew Lunn' <andrew at lunn dot ch>, Jay Foster <jay at systech dot com>
- Cc: "Gaer, A." <Andreas dot Gaer at baslerweb dot com>, ecos-patches at ecos dot sourceware dot org
- Date: Tue, 28 Jun 2005 08:13:27 -0700
- Subject: RE: Race conditions in serial_select
Looks fine to me.
Jay
-----Original Message-----
From: Andrew Lunn [mailto:andrew@lunn.ch]
Sent: Tuesday, June 28, 2005 1:36 AM
To: Jay Foster
Cc: 'Andrew Lunn'; Gaer, A.; ecos-patches@ecos.sourceware.org
Subject: Re: Race conditions in serial_select
On Mon, Jun 27, 2005 at 01:11:39PM -0700, Jay Foster wrote:
> In the existing code, it looks like cbuf is assigned either the value
> &chan->in_cbuf or &chan->out_cbuf, depending on the value of 'which'
> (CYG_FREAD or CYG_FWRITE). In the proposed patch, it is always assigned
the
> value &chan->in_cbuf. This probably is not what was intended.
Duh!
After a nights sleep i tried again....
Andrew