This is the mail archive of the ecos-patches@sources.redhat.com mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Object File Loader


Jani Monoses <jani@iv.ro> writes:

> A couple minor observations.

> > --- anoncvs_clean/ecos/packages/services/objloader/current/cdl/objloader.cdl	1970-01-01 01:00:00.000000000 +0100
> > +++ anoncvs_patch/ecos/packages/services/objloader/current/cdl/objloader.cdl	2005-06-28 16:24:15.000000000 +0100
> [...]

> > + +#        cdl_option CYGBLD_OBJLOADER_ARCHITECTURE_ARM {
> > +#            display       "Support loading on ARM processors"
> > +#            calculated    CYGPKG_HAL_ARM
> > +#            define_proc {
> > +#               puts $::cdl_header "#include <cyg/objloader/relocate_arm.h>"
> > +#            }
> > +#            compile relocate_arm.c
> > +#        }
> > +#    }

> look like an extra brace is commented out here, making all subsequent
> options be under the architecture component and needing an extra
> closing brace at the end.

Hmm, I wonder why ecosconfig didn't complain about that when I tried
it out before?


> ...
> > diff -r -U5 -N -X /home/nickg/diffex anoncvs_clean/ecos/packages/services/objloader/current/ChangeLog anoncvs_patch/ecos/packages/services/objloader/current/ChangeLog
> > --- anoncvs_clean/ecos/packages/services/objloader/current/ChangeLog	1970-01-01 01:00:00.000000000 +0100
> > +++ anoncvs_patch/ecos/packages/services/objloader/current/ChangeLog	2005-06-28 16:22:31.163780522 +0100
> [...]
> > +// Alternative licenses for eCos may be arranged by contacting Red Hat, Inc.
> > +// at http://sources.redhat.com/ecos/ecos-license/

> the redhat line sneaked in this file :)

Grrr, I thought I had exterminated them all. Now stamped on.

> 
> also cyg/kernel/kapi.h is included in several files even if there's no
> explicit dependency on the KERNEL package in the CDL, and I didn't see
> use of kernel functions in the code except in the tests.

Good catch. We may want to get this to work in RedBoot at some point,
so keeping the kernel dependencies low now is a good idea.

I'll fix all of these issues in the final checkin.

-- 
Nick Garnett                                     eCos Kernel Architect
http://www.ecoscentric.com                The eCos and RedBoot experts


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]