This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: AW: another wakep call
- From: <bob dot koninckx at o-3s dot com>
- To: Norbert Peschel <N dot Peschel at conergy dot de>
- Cc: ecos-patches at sources dot redhat dot com
- Date: Wed, 17 Aug 2005 10:05:01 -0400
- Subject: Re: AW: another wakep call
Hi Norbert,
You're probably not going to like this, but, wow, you're
making it even harder to review by sending everything. I
suppose you mean anoncvs of august 14th, with 14.8.05 trunk?
If this is the case, just cd to the packages directory and
type
cvs diff -U -N5 > my.patch
on the command line. The file my.patch now only contains what
you modified (search this list, you'll find numerous examples
of such patch files). Pls send patches in this format to this
list, otherwhise, chances are still odd that anyone will ever
look at them, simply because it takes too much time finding
out what exactly the modifications are.
As an alternative, you can place a file called .cvsrc in your
home dir and add a line
diff -U -N5
to it. All you have to do now is enter cvs diff > my.patch on
the command line. Also don't forget to make a ChangeLog entry
when fixing things.
Thanks for reporting problems.
Bob
---- Original message ----
>Date: Wed, 17 Aug 2005 09:48:47 +0200
>From: "Norbert Peschel" <N.Peschel@conergy.de>
>Subject: AW: another wakep call
>To: <ecos-patches@sources.redhat.com>
>
>Hi Gary, hi Bob
>
>Plus, it is much effort to patch each version again ;)
>You can compare/replace the code directly to 14.8.05 trunk.
>
>kernel.h : brackets missing in macros
>tftp_server.c : we have ram addresses starting at 0x80000000
> ehich makes success checks for < 0 not
working
>httpd.c : good-weather-code, especially getc() can
> return -1 anytime which will loop endlessly
> and block all lower priority tasks (e.g. ppp)
>
>pppd.c : I ended up seeing your linked timeout-list
> screwed up (circular), this all vanished with
> the mutex around its access
> I found an echo-Reply timeout event left
on the
> list in case the line timed out, if that
happens
> too often the line immediately times out
on re-
> connect, fixed it by cleaning up the list
> manually (cleantimeout)
>sys-ecos : I saw the pppd_main immediatly failing (due
to
> the errors above) and ppp_up() waiting
forever
> für !PHASE_DEAD long after pppd_main had
died.
>
>The ppp-fixes are certainly not what you want (fixing effects
>of bugs) but for me they to their job.
>
>Regards, Norbert
>
>-----Ursprüngliche Nachricht-----
>Von: Gary Thomas [mailto:gary@mlbassoc.com]
>Gesendet: Mittwoch, 17. August 2005 00:47
>An: bob.koninckx@o-3s.com
>Cc: Norbert Peschel; eCos patches
>Betreff: Re: another wakep call
>
>On Tue, 2005-08-16 at 07:40 -0400, bob.koninckx@o-3s.com
wrote:
>> Why don't you not propose a solution and send a patch?
>> (that's what the list is called anyway, ecos-patches :-)
Makes it much
>> easier/less time consuming for the maintainers to review
and apply if
>> considered appropriate.
>
>Plus, you've (Norbert) analyzed the failure and know at
least one way to solve it. The maintainers can then look at
this and decide whether to accept your patch directly (likely
if it's
>reasonable) or use it as information to develop a different
one.
>
>As Bob said, that's what this list (and eCos) is all about.
>We've shared the sources with the world, it's only fair when
the world share their improvements, etc.
>
>Thanks
>
>--
>------------------------------------------------------------
>Gary Thomas | Consulting for the
>MLB Associates | Embedded world
>------------------------------------------------------------
>
>________________
>my_patch.zip 51k bytes