This is the mail archive of the
ecos-patches@sourceware.org
mailing list for the eCos project.
Re: [PATCH] ISR not causing an DSR in some rare conditions
- From: Nick Garnett <nickg at ecoscentric dot com>
- To: Andrew Lunn <andrew at lunn dot ch>
- Cc: Sergei Organov <osv at javad dot com>, ecos-patches at sources dot redhat dot com
- Date: 08 Feb 2006 11:24:49 +0000
- Subject: Re: [PATCH] ISR not causing an DSR in some rare conditions
- References: <74C9525D67A5FF4791614FDB06593BB1028546@mail.systech.com> <ds82nd$4bm$1@sea.gmane.org> <20060208102950.GF16327@lunn.ch>
Andrew Lunn <andrew@lunn.ch> writes:
> On Mon, Feb 06, 2006 at 08:58:05PM +0300, Sergei Organov wrote:
> > Jay Foster <jay@systech.com> writes:
> > > Revised patch attached.
> >
> > The patch looks OK to me, but I don't see it applied to the public CVS
> > :(
>
> Is the general consensue that this patch is OK now? If so i will
> commit it.
Yes, it looks OK. At least it will do no harm.
My one reservation is that we still don't have a good explanation for
why this hasn't caused problems in the past. This is a serious
register corruption bug in a very frequently executed piece of
code. Yet we have never seen any problems that could be attributed to
it. It just leaves me with a vague feeling of unease.
However, that's just me, it shouldn't prevent the patch being applied.
--
Nick Garnett eCos Kernel Architect
http://www.ecoscentric.com The eCos and RedBoot experts
Besuchen Sie uns vom 14.-16.02.06 auf der Embedded World 2006, Stand 11-222
Visit us at Embedded World 2006, NÃrnberg, Germany, 14-16 Feb, Stand 11-222