This is the mail archive of the ecos-patches@sourceware.org mailing list for the eCos project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: realtime data logging with colored output


On Thu, Jun 08, 2006 at 07:09:52PM +0200, Thomas H?henleitner wrote:
> Hi everybody reading this,
> 
> attached is a trial implementing a data logger and it would be a pleasure
> for me if you like it.
> 
> Short description:
> ==================
> A colored realtime data logger allowing logging inside and outside of
> interrupts.
> Has the option to detect one or several repeated logs.
> Logs are stored in a log buffer (just string address and parameter) and
> emitted in the background. Logs are with tags which are used during compile
> time (if special tag logs are compiled), during runtime (if compiled
> special tag logs are visible) and for colored output if enabled.

Hi Thomas

As is the code is not very useful. Please could you turn it into an
eCos package. Maybe put it under packages/services/logging/colour/

Also, you need to sort out the name space polution. All public
functions/macros should have cyg_/CYG_ prefixes. This is particularly
important for this sort of code which has to be usable everywhere.

You should add CDL to control the different build options, eg
CYGSEM_COLOUR_LOG_DETECT_REPEATED_LOGS
CYGSEM_COLOUR_LOG_COLORED_LOGGING
CYGNUM_COLOUR_LOG_MAX_LINE_LENGTH 
etc.

You might want to remove os.h and directly call the relevent
functions. 

It would also be good to write some documentation in SGML.

Please could you also summaries how this is better/different to the
existing CYG_TRACE code.

         Thanks
                Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]